Hi Frank,

Finally got a change to play with the DataSourceEditor a bit - the
version included with If_TEST.

Some remarks and suggestions follow, for all to enjoy.

First, I had to change the IBO40EDT_C5 project sources (.cpp and .bpk)
because the DSE wasn't included there like it was with _D5 and _D6.
Discrimination! :-)
Okay, I'll mail you the updated project source.

That done - and IBO40EDT rebuilt - it worked right away if I
double-clicked an IB_DataSource icon. First impression: very crowded
little window, but also very handy. I don't know if I'll use it a lot
because I usually have my DataSources on a Data Module, cosily side by
side with their datasets. On the other hand: your DSE might be a good
reason to move some DataSources to the forms where the controls are.

One thing could be improved, I think: You've made the DSE window
non-modal, so as a user you tend you 'click away' from it without
closing it, e.g. to move some of the generated controls around the
form. Then you want to add some more controls, and you don't see the
DSE anymore so you doubleclick the DataSource icon again, etc.

Everytime you doubleclick the DS icon, a new DSE window pops up, but
in exactly the same spot so you are inclined to think that you have
brought your old DSE to the front. This feller then happily generates
new controls for you, but of course it starts on the same coordinates
so the new controls obscure the others. Later, you discover layer upon
layer of controls, and a bunch of buried DSE windows :-)

Admitted: this doesn't _have_ to happen, and if you pay good attention
it won't. Still, I think it would be best if
- you either made the DSE modal, like the Query Editor etc.
- or, if it stays non-modal: make it so that if you doubleclick a DS
icon that already has an open (but probably hidden under a form) DSE
window, bring that existing DSE window to the front again, instead
of creating a fresh one.

Personally, I would prefer the latter.


I also got the DataSourceEditor to work in Delphi 4, but that required
a number of code changes in IB_DataSourceEditor.pas. Some of them are
really ugly QUAD tweaks, partially because I'm not as familiar with
Delphi as I am with BCB, and partially because I just wanted the damn
thing to work as quickly as possible...

Are you interested in those D4 code changes? They will require some
more work on your part before you can call them "decent", I'm afraid.


Greetings,
Paul Vinkenoog