Hoi Paul,

Paul Vinkenoog wrote:

> Hi Frank,
>
> Finally got a change to play with the DataSourceEditor a bit - the
> version included with If_TEST.
>
> Some remarks and suggestions follow, for all to enjoy.
>
> First, I had to change the IBO40EDT_C5 project sources (.cpp and .bpk)
> because the DSE wasn't included there like it was with _D5 and _D6.
> Discrimination! :-)
> Okay, I'll mail you the updated project source.

thanks, got them.

> That done - and IBO40EDT rebuilt - it worked right away if I
> double-clicked an IB_DataSource icon. First impression: very crowded
> little window, but also very handy. I don't know if I'll use it a lot
> because I usually have my DataSources on a Data Module, cosily side by
> side with their datasets. On the other hand: your DSE might be a good
> reason to move some DataSources to the forms where the controls are.

that's what i usually do, to be honest i haven't tested with
datasources on datamodules, but will do so. it'll require
some more test code (is the datamodule "reachable" from the form
you put the ctrls on etc.), but it's doable.

> One thing could be improved, I think: You've made the DSE window
> non-modal, so as a user you tend you 'click away' from it without
> closing it, e.g. to move some of the generated controls around the
> form. Then you want to add some more controls, and you don't see the
> DSE anymore so you doubleclick the DataSource icon again, etc.
>
> Everytime you doubleclick the DS icon, a new DSE window pops up, but
> in exactly the same spot so you are inclined to think that you have
> brought your old DSE to the front. This feller then happily generates
> new controls for you, but of course it starts on the same coordinates
> so the new controls obscure the others. Later, you discover layer upon
> layer of controls, and a bunch of buried DSE windows :-)

ok, i never used it that way ( the old story; someone who _writes_ a
program is the wrong one to _test_ it ;-) ) but what you say makes
perfect sense. I'll probably make it an option to show the window modal
because - see below:

> Admitted: this doesn't _have_ to happen, and if you pay good attention
> it won't. Still, I think it would be best if
> - you either made the DSE modal, like the Query Editor etc.

that's possible (in fact it's easy, and that was what my first version
did <g>), but then you couldn't move the controls around without
closing and re-opening the editor every time (no moving when a
modal form is open...). it annoyed me so much that i made it non-modal
in the end.

> - or, if it stays non-modal: make it so that if you doubleclick a DS
> icon that already has an open (but probably hidden under a form) DSE
> window, bring that existing DSE window to the front again, instead
> of creating a fresh one.
>
> Personally, I would prefer the latter.

yup, that sounds good. seems the best alternative between how it behaves
now and a ShowModal - until Borland implements
ShowALittleModal(ButOnlyJustALittle); :-)

>
> I also got the DataSourceEditor to work in Delphi 4, but that required
> a number of code changes in IB_DataSourceEditor.pas. Some of them are
> really ugly QUAD tweaks, partially because I'm not as familiar with
> Delphi as I am with BCB, and partially because I just wanted the damn
> thing to work as quickly as possible...
>
> Are you interested in those D4 code changes? They will require some
> more work on your part before you can call them "decent", I'm afraid.

hmm, i don't have D4 any more, but if you can point out what needs to
be changed i can give it a try.

> Greetings,
> Paul Vinkenoog

thanx for the suggestions!

cheers,
Frank