Hello,

I've continued to develop the type 2 driver modifications. The main things
I've done since my last post are:

1) Exposed type 2 driver.

a) Through DriverManager.getConnection() using url 'jdbc:firebirdsql:native
etc etc'. Url 'jdbc:firebirdsql etc etc' uses type 4 as normal.

b) Through FBManager. There has now a constructor which takes a Type(a
typesafe enumeration public on FBManager). eg. new FBManager(Type.TWO)
or new FBManager(Type.FOUR) - the default constructor creates a type 4 as
normal.

2) Modified tests for so that tests in packages 'jca', 'jdbc' and
'management' get run against the driver in type 2 mode and type 4 mode.
Properties in the build file can be used to remove the type 2 or type 4
tests from these packages individually. This doesent require the tests
themselves to know which versions there executing against - they just must
export a custom test suite object.

I may not have done this in the best possible way. I've uploaded
'example_of_test_reports.zip' to
http://groups.yahoo.com/group/Firebird-Java/files/ - so that people can see
how these changes affect the output.



I havent heard anything from Blas regarding the testing on the jar file I
made available.

I have now made available 'firebirdsql-full_withtype2changes_02.jar' which
incorporates these latest changed. The type for functionality can be tested
on windows by taking the file 'native/x86/win32/fbjclient.dll' from within
this jar file out onto the path for the application or into System32 and
then using one of the methods described above to use type 2 mode.

I'm waiting still for the go ahead to commit these mods.
My questions before commiting are:

1) Blas, have you had a chance to test the jar - did you find any problems -
are you happy for me to commit or do you have any further questions or any
objections ?(You may wish to also test the latest
'firebirdsql-full_withtype2changes_02.jar' i've uploaded).

2) David, Are you happy for me to commit these changes ? Or do you have any
questions/objections before hand ?

There is a fair bit too these modifications - but considering - the
modifications to existing code is not really hugley extensive.

Thanks
Ryan

-----Original Message-----
From: Ryan Baldwin [mailto:ryan.baldwin@...]
Sent: 28 May 2003 17:03
To: blas@...
Cc: Firebird-Java@yahoogroups.com
Subject: RE: [Firebird-Java] Re: Type 2 driver modifications are ready
for review.


Hi,

I've uploaded firebirdsql.jar to the files area on the yahoo site. Its name
is firebirdsql_withtype2changes.jar.
This is built from my current working copy using jdk 1.3.1_08. The type 4
functionality (should) be 100% intact.

One thing I am aware of is that TestFBWrappingDataSource::testPooling always
seems to fail with

testPooling Failure Wrong number of connections! 3, expected 2

junit.framework.AssertionFailedError: Wrong number of connections! 3,
expected 2
at
org.firebirdsql.jdbc.TestFBWrappingDataSource.testPooling(TestFBWrappingData
Source.java:178)

This occurs with me when using a fresh checkout also so seems to be
unreleated too my changes.

Please excuse the incomplete post I just made.

Thanks
Ryan


-----Original Message-----
From: Blas Rodriguez Somoza [mailto:blas@...]
Sent: 28 May 2003 14:57
To: Firebird-Java@yahoogroups.com
Subject: Re: [Firebird-Java] Re: Type 2 driver modifications are ready
for review.


Hello

At 27/05/2003 15:27 +0000, Roman Rokytskyy wrote:

>Ryan,
>
> > I've got to the point now where the Type 2 driver modifications made
> > against the head of the CVS tree are ready for review - and in my
> > opinion could be/maybe should be commited before completing the
> > modifications.
> > ...
> > Basicly I would like to have this reviewed and the possibility of
> > having it commited looked at as really I could do with some help in
> > surfacing this through FBDriver and the other methods of obtaining
> > connections which I do not have an extensive understanding of. Also
> > there will be numerous other small things to polish to complete the
> > intergration of these changes - and there are various options for
> > doing these which perahps should be discussed.
> >
> > So if anyone is still interested in having these modifications
> > commited to the tree please let me know and I will make a snapshot
> > of my local CVS tree available through the downloads area and give
> > an thorough overview of what I have had to do and my reasoning.
>
>Personally I would say that you should commit them to the CVS, if your
>changes do not break the driver (at least all test cases should pass).
>I will be able to work on JayBird not earlier than in 2 weeks and my
>plan is to fix multi-threading issues first. Therefore I would like
>that your changes are already in the tree, because it might happen
>that some refactoring is needed.
>
>So, if David and Blas have no objection, I would say "commit".

Only two question for Ryan before:

1.- Can you send me a firebirdsql.jar?. I'll test it.
2.- Why do you want to enable the two types (2 /4) simultaneously and how
do you intend to achieve that?.

Regards
Blas Rodriguez Somoza




To unsubscribe from this group, send an email to:
Firebird-Java-unsubscribe@yahoogroups.com



Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/





To unsubscribe from this group, send an email to:
Firebird-Java-unsubscribe@yahoogroups.com



Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/