> This reminds me that I probably have to do some additional work to
> support
> all properties in the new ConnectionPoolDataSource and XADataSource
> implementation, or at least need to double check this.

I have implemented the nonStandardProperty setters in the old pool
code. The idea was that to create getters/setters for each DPB property
would be an overkill, so it accepted a text "property=value" and passed
that text below to the driver level. The same code was used to parse the
non-standard properties on the pool level and in JDBC url.

If you have implemented that part, it should be enough.

Roman