Subject | strange code in org.firebirdsql.jdbc.FBStatementFetcher.fetch() |
---|---|
Author | Tzvetan Mikov |
Post date | 2005-12-23T02:28:02Z |
First I want to say hello to the list and apologize in advance if my
question has been discussed.
I was playing around with jaybird-2.0.1 and noticed something strange
in org.firebirdsql.jdbc.FBStatementFetcher.fetch().
The lines of code that bother me are these:
int maxRows = 0;
if (maxRows != 0) maxRows = this.maxRows - rowNum;
int fetchSize = this.fetchSize;
if (fetchSize == 0) fetchSize = MAX_FETCH_ROWS;
if (maxRows != 0 && fetchSize > maxRows) fetchSize = maxRows;
Notice that maxRows (the local variable) is always zero and
consequently the two conditions are never satisfied.
This code was introduced in revision 1.20:
http://cvs.sourceforge.net/viewcvs.py/firebird/client-java/src/main/org/firebirdsql/jdbc/FBStatementFetcher.java?r1=1.19&r2=1.20
Is this a bug or just something that is temporarily disabled on purpose ?
regards,
Tzvetan
question has been discussed.
I was playing around with jaybird-2.0.1 and noticed something strange
in org.firebirdsql.jdbc.FBStatementFetcher.fetch().
The lines of code that bother me are these:
int maxRows = 0;
if (maxRows != 0) maxRows = this.maxRows - rowNum;
int fetchSize = this.fetchSize;
if (fetchSize == 0) fetchSize = MAX_FETCH_ROWS;
if (maxRows != 0 && fetchSize > maxRows) fetchSize = maxRows;
Notice that maxRows (the local variable) is always zero and
consequently the two conditions are never satisfied.
This code was introduced in revision 1.20:
http://cvs.sourceforge.net/viewcvs.py/firebird/client-java/src/main/org/firebirdsql/jdbc/FBStatementFetcher.java?r1=1.19&r2=1.20
Is this a bug or just something that is temporarily disabled on purpose ?
regards,
Tzvetan