Subject RE: [Firebird-Java] Re: Type 2 driver modifications are ready for review.
Author Roman Rokytskyy
Hi,

> David has not commented regarding commiting these changes. Shall
> I go ahead and commit them? If you are happy with this and there are no
> other objections I will do so tonight.

I think you should proceed. I see no point of waiting any longer.

> First I will commit simply the modifications and additions to the
> java code. We can then be sure that these dont break any existing
> code and also will commit the modifications to build.xml that
> allows the native code to be built on various platforms.

Can you keep the build file for native part separated from build.xml and
include it using Ant's <ant/> task?

> Second in a few days time - the modifications to the test cases - so
> that some tests can be run in type 4 or type 2 mode by setting
> parameters in build.xml.

Fine with me.

Roman