Right-0, that's exactly what I thought when I took a look (and applied your
3 patches).

It did get me thinking again about a refactoring I've been wanting to do
for a very long time, namely

1. removing the data from XSQLVAR, so it just has type and size info

2. making a subclass for each firebird native data type and moving the
stream reading/writing into these subclasses. This should remove all the
case statements from GDS_Impl, replacing them with polymorphism.

3. Possibly making some kind of row object that has the array of XSQLVAR
subclasses and an Object[] for the current row.

Thanks
david jencks

On 2002.08.26 18:23:21 -0400 AlwaysLinux2 wrote:
> Hmm. that would make sense, but FBField.isNull()'s current
> definition is :
> return (field.sqlind== -1);
> (line 157 of FBField.java)
>
> I guess I could have fixed that line instead to something like
> return (field.sqldata == null);
> but then I wouldn't have been sure (short of a comprehensive code
> review) that nothing else looked at sqlind, so I would still have
> done the fix in GDS_Impl, just to be on the safe side.
>
> Jeremy Williams
>
> --- In Firebird-Java@y..., David Jencks <davidjencks@d...> wrote:
> > Thanks, I hope to look at this tonight.
> >
> > I will have to look hard at the sqlind situation, since the last
> time I
> > worked on that code I thought I modified everything to decide if a
> field
> > was null based on whether the object holding the field was null.
> If I
> > can't sort out the situation I will just apply your patch.
> >
> > Many thanks!
> >
> > david jencks
> >
>
>
>
>
> To unsubscribe from this group, send an email to:
> Firebird-Java-unsubscribe@yahoogroups.com
>
>
>
> Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/
>
>
>
>
>