I aggree. There is a LOT of this in the code. For example,
C files that define the same function for 4 or 5 different platforms.

There ARE places where ifdefs in the code are the right thing to do,
but these aren't them. IMHO, fixing this sort of stuff isn't
that urgent. It's not THAT hard to follow or modify. On the other
hand, the great thing about open source is that if someone does
have the time to spend on it, they can.

Jan Mikkelsen wrote:

>
> Yes. But I don't think they should be #ifdefs.
>
> For example, jrd/time.h is on the right path. Instead of having #ifdefs
> throughout the code to pull in the right system provided time.h, the code
> includes jrd/time.h, which contains the #ifdefs. However, rather than
> having one file which contains essentially six (in the case of jrd/time.h)
> different versions depending on the proprocessor, have six files and use the
> appropriate one for the build at hand.
>
> Generic makefile rules can be easily written to handle this approach without
> the requirement for something like an autoconf harness to build a set of
> preprocessor definitions.
>
> Jan Mikkelsen
>

--
Reed Mideke rfm(at)cruzers.com
If that doesn't work: rfm(at)portalofevil.com