On 07/13/2011 02:12 PM, Philippe Makowski wrote:
>
> By the way, I think we can improve firebird dialect in sqlachemy, even
> with kinterbasdb
>
Looking through the tests and noted that:

- "test_queued_select" is not run for FB, if I let it be run it passes
OK for me with FB 2.5
- "test_nowait_select" would this be "WITH LOCK" in FB?
- "test_queued_update" seems to loop if I let it run

With regards to "test_nowait_select" would this code be o.k. (based on
similar code in the Oracle engine)?

def for_update_clause(self, select):
if self.is_subquery():
return ""
elif select.for_update == "nowait":
return " FOR UPDATE WITH LOCK"
else:
return super(FBCompiler, self).for_update_clause(select)

Or is it more complex as this, i.e. needs appropriate setting of the
"TPB mode" - in which case I better get out of the way:-) .

Werner