firebird-python - Re: [firebird-python] pyfirebirdsql commit and rollback

Subject	Re: [firebird-python] pyfirebirdsql commit and rollback
Author	Hajime Nakagami
Post date	2011-06-08T01:00:35Z

Umm

There was no deep idea.

But I think it is better to finish commit() and rollback() without self.begin() .

So now delete transaction handle attribute only

(and It will be begin() later)

https://github.com/nakagami/pyfirebirdsql/commit/876dabefd8428ae232db254b9b8dbeed8a62d68e

Thanks

2011/6/8 Philippe Makowski <makowski@...>

Hi,

I have one question about the code
why in commit and rollback you finish with self.begin()

this lead to open a new transaction as soon as you do commit or a rollback

is that really a good behavior ?

what all of you think about this ?
are you expecting this behavior ?