Subject | Re: [firebird-php] someone is trying to patch the drupal7 driver |
---|---|
Author | Lester Caine |
Post date | 2012-01-05T09:46:39Z |
mariuz wrote:
so convoluted I kept hitting edge cases.
This particular one should be managed in 'createFieldSql' ...
That said, I can't actually see a 'NULL' on it's own in the firebird driver, I
suspect it should be a 'NOT NULL' for a potential primary key
AH - 'createTableSql' does not even have the code to handle primary key! That
needs to be borrowed from the postgres version of the driver.
One of the reasons I gave up with Drupal was the lack of 'sequence/generator'
management. Since the earlier GOOD code was ripped out and replaced by PDO, much
of the ideal abstraction methods had been lost. In bitweaver all the primary
keys are managed via generators and these are mirrored by sequences on other
databases. Only MySQL has to have that layer simulated which is one reason why
PDO is simply NOT a good starting point since it is too MySQL sentric :(
--
Lester Caine - G8HFL
-----------------------------
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk//
Firebird - http://www.firebirdsql.org/index.php
> I didn't checked it yet but you can give a hand / patchI did spend some time looking at Drupal but their method of abstracting SQL was
> http://drupal.org/node/362178#comment-5068548
so convoluted I kept hitting edge cases.
This particular one should be managed in 'createFieldSql' ...
That said, I can't actually see a 'NULL' on it's own in the firebird driver, I
suspect it should be a 'NOT NULL' for a potential primary key
AH - 'createTableSql' does not even have the code to handle primary key! That
needs to be borrowed from the postgres version of the driver.
One of the reasons I gave up with Drupal was the lack of 'sequence/generator'
management. Since the earlier GOOD code was ripped out and replaced by PDO, much
of the ideal abstraction methods had been lost. In bitweaver all the primary
keys are managed via generators and these are mirrored by sequences on other
databases. Only MySQL has to have that layer simulated which is one reason why
PDO is simply NOT a good starting point since it is too MySQL sentric :(
--
Lester Caine - G8HFL
-----------------------------
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk//
Firebird - http://www.firebirdsql.org/index.php