On 29-10-2018 15:41, vasiliy.yashkov@... [Firebird-Java] wrote:

> Hi!
> I made PR of existing developments -
> https://github.com/FirebirdSQL/jaybird/pull/19.
> Waiting for feedback, suggestions.

Thanks, I will take time to review this, but I'll try to get it done
this weekend.

As I mentioned back in February, given it is a significant contribution,
I will need to have a signed Contributor License Agreement from you, as
I want to be able to release Jaybird under a different open source
license. You can find it on
https://github.com/FirebirdSQL/jaybird/blob/master/licenses/jaybird-icla.txt
. You can either fill it in and sign it with GPG, or print it out, sign
it and send me a copy or photo of the document.

I will probably do some review and leave comments during the week, but I
suggest that you only respond to comments that ask for clarification,
but hold off making changes until I have let you know I'm done. My
review habits are iterative, and I also leave comments as sign posts for
myself, and remove or revise them when I better understand the code.

Mark
--
Mark Rotteveel