Subject Re: [Firebird-Java] Possible memory leak in EncodingFactory ?
Author Roman Rokytskyy
> Shouldn't it be "translatorCache.put(encoding, result);" ?
> Or it should be cached at all - what is the role of charMapping
> argument - should it be include in cache key ?

Yes, you're 100% right. The only thing is that I know only one client who is
using this feature, so it was definitely not part of the testing.

> Probably we can use the String constructor:
> public String(byte bytes[], int offset, int length, String charsetName)
> Though it can be slower than internal implementation.

No, that was the reason of creating the EncodingFactory at all - we tried to
avoid that constructor.