Subject Re: [Firebird-Architect] Re: External procedures: implementation proposal.
Author Jim Starkey
evgeneyputilin wrote:

>Hi
>
>
>
>>Why ExternalResource class exist? Why create a "close" method that
>>
>>
>we
>
>
>>know that will do "delete this"?
>>Use a virtual destructor.
>>
>>
>We can use virtual destructor only with memory release. We use close()
>for the same reason on which have been entered ib_util_malloc. In
>plugin code implementation like
>::close()
>{
> .....
> delete this;
>}
>
>
May I suggest you use addRef() and release() instead? Use counting
makes many activities much easier.

>>I think ResultSet::getValue should be replaced with
>>
>>
>ResultSet::getValues
>
>
>>getting all the return values in one call.
>>
>>
Unless you have a strong argument to the contrary, I'm going to insist
that you use the ResultSet definition already in use.

--

Jim Starkey
Netfrastructure, Inc.
978 526-1376